bump-versions adds regen case conversion and includes Godot, regression tests#5143
Open
rekhoff wants to merge 4 commits into
Open
bump-versions adds regen case conversion and includes Godot, regression tests#5143rekhoff wants to merge 4 commits into
bump-versions adds regen case conversion and includes Godot, regression tests#5143rekhoff wants to merge 4 commits into
Conversation
Contributor
bfops
approved these changes
Jun 2, 2026
Collaborator
bfops
left a comment
bfops
left a comment
There was a problem hiding this comment.
LGTM. Let's merge this before my PR.
Collaborator
|
to confirm - you checked in your testing that the Godot version and regression-tests were properly bumped? |
Contributor
Author
Yes, in my testing the following where propperly updated to the target version:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This addresses issue #5121 by updating the
bump-versionscargo command to include:.csproj.csprojAPI and ABI breaking changes
No API or ABI changes
Expected complexity level and risk
1 - Small and strait forward
Testing
cargo bump-versions --all 2.3.0-test --accept-snapshotslocally from the root of the repo, and confirmed that ~25 files being modified.